Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PVC or EmptyDir for Storage #67

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Implement PVC or EmptyDir for Storage #67

merged 2 commits into from
Mar 23, 2024

Conversation

sircthulhu
Copy link
Member

@sircthulhu sircthulhu commented Mar 22, 2024 •
edited
Loading

Implemented a PVC/emptyDir support for etcd.
Checked that everything works fine in local Kind cluster version 1.27.3
fixes #49

@sircthulhu sircthulhu enabled auto-merge (squash) March 22, 2024 13:50
@lllamnyp
Copy link
Collaborator

Didn't check everything down to the last semicolon, but the concept looks great!

@kvaps kvaps mentioned this pull request Mar 22, 2024
Closed
sergeyshevch
sergeyshevch approved these changes Mar 22, 2024
View reviewed changes
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
@sergeyshevch sergeyshevch mentioned this pull request Mar 22, 2024
Closed
@kvaps kvaps mentioned this pull request Mar 22, 2024
Open
@sircthulhu sircthulhu merged commit 5715962 into main Mar 23, 2024
3 checks passed
@sircthulhu sircthulhu deleted the feature/49-impl-spec-storage branch March 23, 2024 09:11
@sircthulhu sircthulhu added the feature New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uburro Uburro Uburro approved these changes

@sergeyshevch sergeyshevch sergeyshevch approved these changes

@kvaps kvaps kvaps approved these changes

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar Kirill-Garbar is a code owner

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ".spec.storage"
5 participants
@sircthulhu @lllamnyp @kvaps @sergeyshevch @Uburro